Salvatore Formisano
Salvatore Formisano
New .NET and C# guy here, so please take this with a grain of salt. I've learned a lot from this repository, but one thing that really sticks out for...
We want to encourage devs to use nonces in their form submission processing. Add an example in the README to show that nonces are easy to use with the jetrouter
You may want to use this router in a WordPress plugin. Great! But there's a problem when adding this router as composer dependency through composer and wpackagist. For some reason...
Have the route definition include an optional 'before' function or something along those lines. If defined this function should return a truthy value for the route callback to fire.
It may be a good idea to make reverse routing available via JS. We could use a WordPress hook to make a js object with all the data required for...
Data providers are too bloated, no solid naming convention for test methods nor for data providers. Unit tests need to become more clear and concise.
When the router has to dispatch a dynamic route, it has to go through the dynamic routes generation process every time. This becomes a performance concern as the dynamic routes...