Shane F. Carr

Results 2307 comments of Shane F. Carr

OK, sure, in the temporal_rs FFI, you would either need to return an ICU4X `ffi::Date` or else return your own little wrapper type thing for formatting, which now I see...

You should definitely store at least a UtcOffset in ZonedDateTime.

In the medium term, I would like to see tests like these moved into the new Unicode Conformance test suite (CC @sven-oly @gnrunge), moving the burden for updates to a...

From brief discussion with @robertbastian: We want to keep these tests, and the JSON file is cleaner in terms of source code than inlining everything. It would be nice if...

Yes, if the editors approve, please merge; we shouldn't let PRs stay open this long

I agree there's room for improvement here. If `icu_properties` is all singleton keys, we could likely drop the `icu_locid_transform` dependency (note: crates are being reorganized in 2.0, but we wouldn't...

@robertbastian Do you agree with the above conclusion?

Does the following unattributed comment (I think from @Manishearth?) address your concern? > The main cost of splitting [the exemplar chars functionality into a child crate] in the future is...

I don't think that's a question that can be answered at the moment since this is about future-proofing. Maybe exemplar chars data decides to add a lot more details, like...