Konstantinos Kloudas

Results 6 comments of Konstantinos Kloudas

@sfc-gh-tzhang > Thanks for the change, two questions: > > 1. Could you update SnowflakeStreamingIngestClientInternal.close as well? The reason I did not change this is because I do not know...

Actually I think that for the `client.close()` I think that we should chat because I have some questions that I need to clarify before figuring out a solution. For example,...

> > @sfc-gh-tzhang > > > Thanks for the change, two questions: > > > > > > 1. Could you update SnowflakeStreamingIngestClientInternal.close as well? > > > > >...

Oh now I see your point. I think that the best solution to this is to not expose the `isClosed()` method at all and either make the `close()` blocking (which...

> > Actually I think that for the `client.close()` I think that we should chat because I have some questions that I need to clarify before figuring out a solution....

For the tests now, > LGTM, please make sure you pass all the merge gate, as well as `StreamingIngestIT.java` Now that we changed the semantics of the `isClosed()` to only...