Sevag H

Results 125 comments of Sevag H

>Is it necessary to do resampling on ODF? even if onsetDFBufferSize is equal to output_len? From reading the code it looks like the resampling is always done "just in case",...

Thanks, confirmed this is working for Python 3.8 as well. Have you considered making it support both, by using ifdefs? E.g. ``` #if PY_MAJOR_VERSION >= 3 ``` http://python3porting.com/cextensions.html

Thanks for pointing this out. Do I basically go to every key in the JSON output and just do some string manipulation to convert them to lowerCamelCase? e.g. python pseudocode:...

Here's my attempt: https://github.com/sevagh/pq/pull/75/files#diff-d3074ba1689c29fa340ca2ef02837dfaL37 There's a lot of rules but I made some good progress in making a section where we can define rules easily.

I ran this in prod and it works well. Not sure if I want it to be default or toggleable with a flag. `--compliant`?

I like the idea to switch behaviors and add a legacy flag in the next major release. For now I need to figure out a way to descend into the...

>I have tested v1.0.1. It seems to work very well, but only at the root level, not for sub-objects. Actually maybe I'm misunderstanding the document but it seems to me...

Thanks for the test case. I'll try some things.

I think you're right about maps, this is what a real map looks like: ``` "myChild": [ { "key": "foo_bar", "value": "baz" } ] ``` I created this proto to...

Tentative fix: ``` sevagh:python $ ./proto_encoder.py single nested | ../../target/debug/pq --fdsetfile .. /fdsets/parent_child_nested.fdset --msgtype Parent --canonical { "myChild": { "fooBar": "baz" } } ```