Abdelkader Boudih comments

Results 255 comments of


                                            Abdelkader Boudih

Include ActionMailer::DeliverLater::Mixin in ActionMailer::Base by default

I will to this tomorrow.

Include ActionMailer::DeliverLater::Mixin in ActionMailer::Base by default

Do you think it better if i do it with railtie ?

Include ActionMailer::DeliverLater::Mixin in ActionMailer::Base by default

I will look into it.

Include ActionMailer::DeliverLater::Mixin in ActionMailer::Base by default

So i located the bug not i'm not sure yet how to fix it. When we include the mixing manually we have ``` DelayedMailer, ActionMailer::DeliverLater::Mixin, ActionMailer::Base, ActionView::Layouts, .... ``` with...

Include ActionMailer::DeliverLater::Mixin in ActionMailer::Base by default

I'm looking at the rails source since there is no extra gem that could have added these module. We will have to patch rails 4.1 and 4.2, right ?

Include ActionMailer::DeliverLater::Mixin in ActionMailer::Base by default

I'm sending a little fix right now @cristianbica

Include ActionMailer::DeliverLater::Mixin in ActionMailer::Base by default

@cristianbica https://github.com/seuros/actionmailer-deliver_later/tree/prepend

Include ActionMailer::DeliverLater::Mixin in ActionMailer::Base by default

That still won't fix the issue.

Include ActionMailer::DeliverLater::Mixin in ActionMailer::Base by default

Shouldn't we merge activejob first ? and yes, i can prepare a PR.

Include ActionMailer::DeliverLater::Mixin in ActionMailer::Base by default

Then we can turn this gem to support rails 4.1 only.