Łukasz Setla

Results 9 comments of Łukasz Setla

@Dreamsorcerer can I get some clue if (and when if so) it's going to be merged?

@Dreamsorcerer @webknjaz please let me know if there is anything else to change and resolve conversations if changes cover it

@Dreamsorcerer @webknjaz is it expected that windows tests fail? https://github.com/setla/aiohttp/actions/runs/7765565978/job/21180923429?pr=1 - it shouldn't be related to changes in this PR.

@webknjaz please take a look, i really want to merge this PR :)

> @setla I also really want to merge it. Though, I insist on the exception hierarchy to be corrected first. Non-HTTP URLs are not necessarily invalid, just different. The clients...

@webknjaz fixed, it seems like everything is addressed now, please let me know if there is anything else to do

@webknjaz right, should I create 2 PRs (3.9 and 3.10)? or just one (3.9)? 3.9 is already present https://github.com/aio-libs/aiohttp/pull/8154

@webknjaz okay - I opened PR to 3.10 https://github.com/aio-libs/aiohttp/pull/8158