ember-cli-new-version

ember-cli-new-version copied to clipboard

Bumps [@xmldom/xmldom](https://github.com/xmldom/xmldom) from 0.7.5 to 0.7.9. Release notes Sourced from @​xmldom/xmldom's releases. 0.7.9 Commits Fixed Properly check nodes before replacement [#457](https://github.com/xmldom/xmldom/issues/457) / [#455](https://github.com/xmldom/xmldom/issues/455) / [#456](https://github.com/xmldom/xmldom/issues/456) Thank you, @​edemaine, @​pedro-l9, for...

dependabot[bot]

In development, banner is not dismissible

5

In development, using ember-cli-app-version, the banner is not dismissible because VERSION.txt is not regenerated upon commit.

kategengler

Issues with ember-cli-deploy

1

It seems like this did not work for a much longer time, but I never noticed it because on previous `ember-cli-new-version` versions a `version.txt` containing an invalid version number, would...

st-h

knownasilya

Is removing ember-concurrency a viable option?

1

As ember concurrency adds quite a bit to an applications bundle size, it would be great if this addon wouldn't necessarily depend on it. If this is an option, I'll...

st-h

Provide options for fetch (cors)

1

Hi, i use my app in another app, and i can't do CORS request to /VERSION.txt because fetch method do request without option (mode: 'cors') can you allow setup options...

spr1ne

calling set on destroyed object

3

I am on `1.6.0`, but it appears that this is still an issue on master due to sets being done inside `then` instead of using `yield` and letting ember-concurrency cancel...

Samsinite

It is worthy to mention deployment script modifications for VERSION.txt in the documentation

4

As many would use `ember-cli-deploy`, VERSION.txt should go in separate step, e.g. ```javascript // ./config/deploy.js let ENV = { pipeline: { alias: { s3: { as: ['s3-version', 's3'] }, },...

Romanior

yield inside ember-concurrency finally block

4

On [this line](https://github.com/sethwebster/ember-cli-new-version/blob/62c656473cfb3a5f27ed782f80f8fac6c0e9cba0/addon/components/new-version-notifier/component.js#L79) you're yielding within a `finally`. This is not really a good idea per https://github.com/machty/ember-concurrency/issues/185

bgentry

How to test in development? (ember serve)

5

Hi, really not sure what I'm doing wrong here, but how do I run `ember serve` and test this out? I see the VERSION.txt copied to /dist. I edit dist/VERSION.txt...

derekwsgray