ember-cli-new-version icon indicating copy to clipboard operation
ember-cli-new-version copied to clipboard

Published 20 hours ago • verified publisher icon sethwebster

In development, banner is not dismissible

Open kategengler opened this issue 2 years ago • 5 comments

In development, using ember-cli-app-version, the banner is not dismissible because VERSION.txt is not regenerated upon commit.

kategengler avatar Mar 15 '22 19:03 kategengler

Good catch!

knownasilya avatar Mar 15 '22 19:03 knownasilya

@kategengler #117 was released in v4.1.0. Let me know if that helps.

knownasilya avatar Mar 30 '22 03:03 knownasilya

Also currentVersion not using ember-cli-app-version, its came up null.

Since version 4.0.0 this addons will use the version string provided by ember-cli-app-version if no currentVersion is configured.

yusufsagdic avatar Apr 10 '22 19:04 yusufsagdic

@yusufsagdic does https://github.com/sethwebster/ember-cli-new-version/pull/104 help? It was a breaking change. If not, please open a new issue.

knownasilya avatar Apr 11 '22 16:04 knownasilya

@knownasilya yes, thanks.

yusufsagdic avatar May 01 '22 19:05 yusufsagdic