Kamal Ahmad

Results 45 comments of Kamal Ahmad

@s0r00t Why are you manually editing the URL, why not just pass it as an argument to the downloader?

@aolko why is the source code not available?

I think being able to share the Pool itself across threads will also be nice too. Currently Pool is not Sync as it uses an Rc/RefCell internally.

@hanbu97 Hi, are you interested in working on this? I'd like to take this issue if it's available

Once a scan is registered, it will scan all new blocks, but it's not retroactive. So I think we only need the temp file for the first time we register...

Hmm, 1000 is a pretty safe margin for mainnet. I think it's a good solution

Hmm, after some more thought, I think one way might be to store creation height of pool box in oracle_config.yaml as an optional parameter. The benefit of this would be...

Hmm, I ran into this issue as well when trying to deploy a new refresh contract in update. I think one way might be a way to add expected parameters,...

I wonder whether something like a builder pattern would be better for this. So calls to this for example ```rust #[allow(clippy::too_many_arguments)] pub fn build_refresh_action( pool_box_source: &dyn PoolBoxSource, refresh_box_source: &dyn RefreshBoxSource,...