mozjs

mozjs copied to clipboard

Notes on ESR 128

12

Just some things that I have to be careful about (because I will probably forget them by the summer when ESR lands): - https://github.com/servo/mozjs/blob/main/mozjs-sys/etc/patches/D194086.patch can be dropped due to https://bugzilla.mozilla.org/show_bug.cgi?id=1853564...

sagudev

#446

Taym95

Make ‎TypedArray::update safe

2

I think [`‎TypedArray::update`](https://github.com/servo/mozjs/blob/7184f658b7e2de8a8d288ff39001364513115782/mozjs/src/typedarray.rs#L255) can be made safe, while containing an unsafe block calling `Self::update_raw`, that way we can remove these [kind of unsafe blocks](https://github.com/servo/servo/pull/30990/files#diff-88b03ac9bcc2650883607d41bc374d7f3976567cfbee702cc124f14ce2fbc79bR283) in Servo.

gterzian

Use ANDROID_NDK_ROOT instead of ANDROID_NDK_HOME

2

ANDROID_NDK_ROOT seems to be the more common environment variable nowadays.

mrobinson

Parallel compilation is broken with GNU Make 4.4

8

GNU Make 4.4 breaks the parallel builds in mozjs and behaves as though `-j1` was given, leading to long build times. Relevant logs from `cargo build -vv`: ``` [mozjs_sys 0.68.2]...

mukilan

Added BigInt64 and BigUint64 Typed Array Support

1

redfire75369

Aligned JSVal Implementation with C++ and reduced 32-bit vs 64-bit specific implementations

redfire75369

Added Glue for Functions with `mozilla::Range` Parameters

2

Small change to #433. `slice::as_mut_ptr_range` gives a `Range`, which would need to be converted to a reference to be used.

redfire75369

Switched Bindgen to Use `BINDGEN_CXXFLAGS` Environment Variable

2

Resolves #435, using the second approach mentioned. Will require a change in servo at the following location to `env["CXXFLAGS"] = env["BINDGEN_CXXFLAGS"] = ' '.join([`. https://github.com/servo/servo/blob/bbc35b682f0fb926364e5800d20f77bba944a020/python/servo/command_base.py#L690

redfire75369

Windows Builds Fail when `clang-cl` Flags are added to `CXXFLAGS`

13

The root issue here is that bindgen uses `clang` (not `clang-cl`) on windows, and on unrecognised flags, it fails. Upon adding `CXXFLAGS="/clang:-flto=thin /clang:-fuse-ld=lld-link"`, the below code automatically adds it to...

redfire75369