mozjs icon indicating copy to clipboard operation
mozjs copied to clipboard

Published 20 hours ago • verified publisher icon servo

Switched Bindgen to Use `BINDGEN_CXXFLAGS` Environment Variable

Open Redfire75369 opened this issue 1 year ago • 2 comments

Resolves #435, using the second approach mentioned. Will require a change in servo at the following location to env["CXXFLAGS"] = env["BINDGEN_CXXFLAGS"] = ' '.join([. https://github.com/servo/servo/blob/bbc35b682f0fb926364e5800d20f77bba944a020/python/servo/command_base.py#L690

Redfire75369 avatar Dec 06 '23 16:12 Redfire75369

There is BINDGEN_EXTRA_CLANG_ARGS, could we use it instead of introducing new variable?

sagudev avatar Dec 06 '23 18:12 sagudev

The issue is CXXFLAGS being passed to both bindgen and cc/makefile.cargo, not bindgen itself.

Redfire75369 avatar Dec 06 '23 19:12 Redfire75369