Switched Bindgen to Use `BINDGEN_CXXFLAGS` Environment Variable

Open redfire75369 opened this issue 2 years ago • 2 comments

Resolves #435, using the second approach mentioned. Will require a change in servo at the following location to env["CXXFLAGS"] = env["BINDGEN_CXXFLAGS"] = ' '.join([. https://github.com/servo/servo/blob/bbc35b682f0fb926364e5800d20f77bba944a020/python/servo/command_base.py#L690

Dec 06 '23 16:12 redfire75369

There is BINDGEN_EXTRA_CLANG_ARGS, could we use it instead of introducing new variable?

Dec 06 '23 18:12 sagudev

The issue is CXXFLAGS being passed to both bindgen and cc/makefile.cargo, not bindgen itself.

Dec 06 '23 19:12 redfire75369