serv-inc comments

Results 5 comments of


serv-inc

Are length and total_time same or different?

They seem to be the same (modulo conversion to `int`): https://github.com/liamks/libpytunes/blob/master/libpytunes/Library.py#L82 says: ` s.length = int(attributes.get('Total Time')) if attributes.get('Total Time') else None` The XML calls it _Total Time_.

Create a mock WebExtension API for developers to run unit tests with

Hi @arantius, it seems like you can (always?) use the Firefox APIs like the chrome ones, passing in a callback.

Default value for min-spaces-from-content clashes with prettier

If you try to set this in .pre-commit-config.yaml, the following might work: ``` - repo: https://github.com/adrienverge/yamllint rev: "v1.26.3" hooks: - id: yamllint args: ["-d {extends: default, rules: {comments: {min-spaces-from-content: 1}}}"]...

Replace `@Nonnull(when = When.MAYBE) ` by `@CheckForNull` in `@Nullable`

Does https://stackoverflow.com/questions/61140322/jetty-run-error-java-lang-typenotpresentexception-type-javax-annotation-meta-wh help ? ``` com.google.code.findbugs jsr305 3.0.2 ```

Linter applied for flash_build.py

only FYI: this looks like [black](https://github.com/psf/black) was applied. This is certainly useful for new code, but compatibility with existing code is important, too ([practicality beats purity](https://www.python.org/dev/peps/pep-0020/)).