John Serock

### Contact Details [email protected] ### Describe the Bug The following message is logged when getting the PK UEFI global variable: `ERROR:root:Unexpected attributes value: 39 for PK-8be4df61-93ca-11d2-aa0d-00e098032b8c` A similar message is...

The message for a wrong digest is confusing

5

https://github.com/agama-project/agama/blob/737e17ae67eea515e46e0dd8914a4a6b7d4e8baa/service/lib/agama/software/callbacks/digest.rb#L112-L114 In the message, both the expected and the found checksums are described as "_expected_". Thus, I cannot tell which checksum is wrong. Removing the first "_expected_" from the message...

Copied/pasted error message?

1

Both the `on_target` and `on_local` methods log the same error message. https://github.com/agama-project/agama/blob/bb0e4f3e1dda57c6772405504f59134e2e9415fe/service/lib/agama/helpers.rb#L61 Should the error message in `on_local` (Line 61) say "on _local_" instead of "on _target_"?

Fixes #29 - A simple fix for displaying the input file size.

Fixes #30 - Fix problem where only 31 out of 32 bytes are written for each hash.

https://github.com/nsacyber/Hardware-and-Firmware-Security-Guidance/blob/f87939e3955c741b20e52c9ec0a737435e3939b9/secureboot/esl-parser.py#L102 The `47` should be changed to `48`.

https://github.com/nsacyber/Hardware-and-Firmware-Security-Guidance/blob/f87939e3955c741b20e52c9ec0a737435e3939b9/secureboot/esl-parser.py#L40 The issue is that the string is not an F-string.