Serj Lotutovici

Results 18 issues of Serj Lotutovici

Remove '.idea/' directory form the repo. Group all ignore rules in one '.gitignore' file. Add common dependency map for all used libraries. Cleanup 'markdownview' build script (also remove targetSdkVersion). Cleanup...

* Introduces NativeScreenFactory for android.support.v4.app.Fragment. * Changes NavigatorModule.pushNative() to check for native screen availability. * ReactNavigationCoordinator throws exceptions early if no activity where registered. * Adds Native2Fragment to example app...

The folder and the files are left overs from an older build system and are not needed.

Currently the android library uses Jackson as a serialisation library. This makes Jackson a transitive dependency that lands in the consumers dependency tree. My proposal would be to adapt a...

Currently the `MarkdownProcessor` takes in and returns a `String`. This can become very slow if the markdown if very large. Usually the actual markdown is accessed throw some io operation,...

Currently each resource declares a method, that returns a `CallSpec`, each declared method uses helper factory methods to build the resulting spec. This created multiple problems with the api flexibility,...

enhancement

Currently we are declaring all models manually. This creates an overhead for us when maintaining `hashCode`, `equals()` e.t.c. AutoValue will solve this problem for us. Another pro is the new...

enhancement

Currently the `CallSpecTest` is a mess of tests with deferent scopes. Would be nice to separate the tests. For example like so: - CallSpecBuilderTest - should contain everything related to...

enhancement

We probably want to do this smart. Add common constants to the parent `Resource` class, and domain specific to each respective resource implementation. @akreul @andretietz could you comment on this...

enhancement