seriyvolk83 comments

Results 8 comments of


seriyvolk83

ARVideoKit forces app into portrait mode when starting from landscape left/right.

@jrz-afs https://github.com/AFathi/ARVideoKit/pull/120

ARVideoKit forces app into portrait mode when starting from landscape left/right.

@jrz-afs check #121 instead. It’s an updated version of the fix

[AVAssetWriterInput appendSampleBuffer:] Cannot append sample buffer: Must start a session (using -[AVAssetWriter startSessionAtSourceTime:) first

I think it's fixed here. https://github.com/AFathi/ARVideoKit/pull/122 Let me know if it helps someone.

Correct fix for #1041 and #1038

> Hey @seriyvolk83 I've just noticed your PR, any reason for rolling back the fix? I don’t remember, but seems the first commit has change that is excessive because on...

Correct fix for #1041 and #1038

Btw, #1088 is wrong fix, these mew methods will never be used. Linux has these methods implemented and it’s the reason the code is not complied.

Fixes #1041 and #1038 on linux variants

Consider #1083 instead.

ambiguous use of operator '<'

> I am facing the same issue, but, actually, is this not duplicate of the #1038 ? > > Cheers it is

iOS: Prevents View to push upward when keyboard is active

The name of the variable `bottomOffset` seems incorrect.