Sergiu Deitsch

Results 182 comments of Sergiu Deitsch

Unfortunately, the cleanup tests are still failing.

There are several reasons why pkg-config is no longer installed by default: 1. pkg-config support is undocumented. 2. The support is untested: there are no unit tests ensuring actual usability....

The unit tests are still failing though.

Closing as abandoned. Please let me know if you want to continue working on this PR.

> pkgconfig support is so simple that it does not need any testing. I certainly disagree. There is also no point arguing since you can enable `.pc` file generation at...

Thanks for the PR. Given there are is no feedback and the PR heavily diverged from `master` we can abandon the changes. In case you want continue working on this,...

The difference is expected as per [`gettid` documentation](https://man7.org/linux/man-pages/man3/pthread_self.3.html): > The thread ID returned by this call is not the same thing as a POSIX thread ID (i.e., the opaque value...

> I want to look at which thread caused the crash. Is there a way to know that? I'm not sure I understand what are you asking given you have...

For consistency and information gain both functions should be used.

A couple of suggestions regarding CMake support: * [Drop](https://github.com/opencv/opencv/issues/20198#issuecomment-853029735) legacy style CMake variables such as `OpenCV_LIBRARIES`, `OpenCV_LIBS` etc. * Use CMake [double-colon convention](https://github.com/opencv/opencv/issues/20198#issuecomment-853029735) for import targets (also proposed in #13117)...