Sergiu Deitsch
Sergiu Deitsch
Thanks! #786 seems to be related.
Thanks for the PR. I need some time to look through the changes. In the meantime, could you please rebase onto current head and resolve the conflicts?
In the code above, `DefaultDir` sill uses duplicated logic while the only difference is the use of `getenv` for ANSI and Unicode strings. It is therefore more meaningful to provide...
@xfc1939 Please do not close the PRs to create a new one. Simply update your branch and push the changes. Thank you.
Good catch! After looking into the issue, I believe something like [this](https://compiler-explorer.com/z/9xMaojMPY) could work. `NullStream` should probably not derive from `LogMessage::LogStream` to allow the compiler to optimize the corresponding symbols...
Closing as abandoned. You can rebase anytime if you want to continue working on this PR.
Is this still a problem with glog at head?
I'm closing the issue in preparation for new release. In case the problem persists, please submit a new issue with an updated log.
You can extend any of the `cleanup_*_unittest.cc`, for instance, here https://github.com/google/glog/blob/ac12a9e79440a2a89cc1c5617bb8f6db02035182/src/cleanup_immediately_unittest.cc#L62-L64 by additionally logging at the missing severities. Please note that the unit tests need to be updated either way...