Sergi Siso
Sergi Siso
@LonelyCat124 I put this back with reviewed with actions to clarify if the last commit after your message that this was ready belongs here, because the same commit is also...
> Is the non required -0.01% codecov/project drop an issue? It's been reporting this on my 3 PRs. No, in general we require a 100% of the patch (new code)....
@arporter I am not sure if I understand why do you need to extend the setter? I would expect the Module manager to use the same include_dir (what is passed...
@arporter Does it cache if the regex has found the modules? I am surprised this is necessary, the regex should be very fast. (Unrelated to this PR I am going...
Yes, that PR has a `routine.symbol` similar to the helper methos proposed here. Closing this PR
> No, it caches which directories it has searched. (The concern I think is recursively exploring the directories.) Still, I can grep for a string in all LFRic trunk in...
> It isn't done repeatedly. The search just expands until it finds the requested module. The files it finds on the way are cached so that the next time a...
> Are you sure that the data is not cached by the OS? Aha, yes it was (but also for potentially consecutive psyclone invocations). In my laptop it goes from...
I should also mention that this is not a priority. I would do 1) because it is useful when generating LFRic with all initialisations being proper PSyIR (half are pointer...
> Do we need to pass is_pointer to the assignment as an argument? Surely the assignment can work it out itself The problems is that lhs (and rhs) can be...