Sergi Siso

Results 205 comments of Sergi Siso

> I am mostly happy with this, if my understanding is correct that it mostly replaces NemoLoop with the PSyIR Loop. This is right, and not only NemoLoop, since this...

@arporter This is ready for the first proper review. There is a couple of comments: - All output code after this change is the same with the exception of ji,jj,jk...

> There is still a doctest issue with I can not reproduce locally The reason was that (similar to pytest), doctest keeps the configuration of the previous docstring snippet, and...

@arporter This is ready for another review. I added the DOI badge to the readme in this PR since it was a one-liner, but let me know if you prefer...

This is ready for a first look from @arporter or @hiker . It adds support for pointer assignments (removes the CodeBlocks), but not symbol attributes (does not remove UnknownFortranType for...

@arporter This is ready for next review. In comparison to the first review I found out that pointer expressions that have array accessor ranges in the inner element are not...

@arporter This is ready for another review

Thanks @LonelyCat124 to implement this, looking at NEMO upstream it seems that they all are elemental functions, I think it will work with your implementation but it would be good...

In nemo functions the type is in the declarations (with the same name as the function), not the function line: ``` ELEMENTAL FUNCTION SIGN_SCALAR( pa, pb ) !!----------------------------------------------------------------------- !! ***...