Sergey Chernyshev
Sergey Chernyshev
> Hello Sergey, do you plan to update the PR with the class level doc change suggested by Michael? Hi @jaikiran ! Yes I plan to update the PR. Apologies...
Thanks @Michael-Mc-Mahon, @jaikiran. I updated the class level doc so that the sentence "These forms support parts in decimal format only" is completely removed (it wasn't looking good to me...
@AlekseiEfimov @jaikiran @Michael-Mc-Mahon Could you please take a look and review the [CSR ](https://bugs.openjdk.org/browse/JDK-8329876)?
> Ok - so now we seem to be missing the fact that the _only_ form supported by the existing methods is the decimal form. > Can we find a...
> missing the fact that the _only_ form supported I'd also note that, when mentioned in the docs that this is the _only_ method capable of parsing this type of...
Thank you @AlekseiEfimov, @dfuch for your reviews!
> The new method is not easily discovered, which is okay as it's very much a method for experts, I see wonder if we should put a `@see` in InetAddress.ofLiteral....
> I think you may have mis-read my comment. I think we need to add `@see InetAddress4#ofPosixLiteral(String)` to InetAddress.ofLiteral, not Inet4Address.ofLiteral. The reason is that methods defined by Inet4Address are...