Chris B comments

Results 47 comments of


                                            Chris B

Make YoutubeLinkEnhancement URL parsing more robust.

Ah ok, TIL we still de facto support IE11 😅 If you're sure we need to continue to support embedded YT videos in IE11 for the time being then I'm...

Make YoutubeLinkEnhancement URL parsing more robust.

Do we have a preferred polyfill library for this sort of thing? (Not necessarily suggesting it's worth it, just curious.)

Make YoutubeLinkEnhancement URL parsing more robust.

~Actually wouldn't it be just dropping support for adding/editing YT embeds in the content management tools in IE? Is this library even used in the public-facing frontends?~ Ah no I...

Make YoutubeLinkEnhancement URL parsing more robust.

Even so, I'm not sure this would affect anything public-facing because it's in the govspeak library and surely we're not doing the govspeak->html transform on the client? 🤔

Make YoutubeLinkEnhancement URL parsing more robust.

Aha thanks! Super helpful example ❤️

Make YoutubeLinkEnhancement URL parsing more robust.

I'm guessing this depends on #4000 — does that sound right?

Update clamav/clamav-debian Docker tag to v1.3

~~@dependabot rebase~~ duh it's renovate 🙈