Chris Banks

Results 19 comments of Chris Banks

Cheers for the review, @cbaines! I'll hold off on merging this for now if that's ok, just on the precautionary principle what with it being such a crucial time for...

Thanks for cleaning up these old PRs!

Lol it turns out the tests depend on the defaults. Oh dear.

Oh I thought of another thing: I don't think we'll be able to use an IP allowlist for integration because other gov depts need to access it for training content...

Force-pushed to fix a `terraform lint` alignment nit 🙄

Applied the TF change in all three clusters and restarted everything in order to pick up the readiness gate (`k rollout restart deploy; k rollout status deploy -w`).

FWIW I've been getting around this wrapping my `promql_expr_test` expressions in [`round()`](https://prometheus.io/docs/prometheus/latest/querying/functions/#round). IMHO it feels a bit iffy to be testing exact floating-point equality at all, but hey 🤷 Incidentally,...

A rebase should fix the `ami_type` diff (see #1200). Pretty sure those deprecation warnings are unrelated. (They'll probably go away when we [update the aws-eks module](https://github.com/alphagov/govuk-infrastructure/issues/1202).) No need to paste...

TFC ~definitely~ is supposed to require all users except org owners to authn via SSO in order to access projects owned by the org, so I don't think it's the...

```json {"level":"info","ts":"2024-04-08T16:21:26Z","msg":"version","GitVersion":"v2.7.2","GitCommit":"fb6460383b75e937e24548e69b6732f49b88755c","BuildDate":"2024-03-22T21:39:56+0000"} {"level":"error","ts":"2024-04-08T16:21:29Z","logger":"setup","msg":"unable to initialize AWS cloud","error":"failed to introspect vpcID from EC2Metadata or Node name, specify --aws-vpc-id instead if EC2Metadata is unavailable: failed to fetch VPC ID from instance metadata:...