Shane Emmons comments

Results 52 comments of


                                            Shane Emmons

Test again Rails 5 and 6

looks like it. care to submit a PR to get them back online?

Validation failing when using less than with delimiter equal to '.'

I am not sure Ruby can handle a `,` as a delimiter in a Float itself. I think it can only handle it on the output via the i18n gem....

Validation failing when using less than with delimiter equal to '.'

should we make this a change?

write_attribute private method does not exist anymore in ActiveModel 6.1

@antstorm || @berkos care to submit a PR?

parse_collection will always return default_currency if the string contains symbol

The symbol can be ambiguous—many currencies use $. Therefore, when an explicit `default_currency` is set, we override symbol parsing and use the `default_currency` unless an ISO currency is provided.

test should pass when using dot delimiter and float assignment

happy to merge once tests are passing

`monetize`d attribute autoconverts Hash to Money but validation rejects

can you show the code for `price_in_a_range`?

`monetize`d attribute autoconverts Hash to Money but validation rejects

Looking at the code, it seems like what needs to happen is to cast the hash to a money object right away and use that for validation instead of the...

Version 1.11.0 broke parsing for Malaysian ringgit when using the symbol 'RM'

@antstorm I feel this is a regression and we should accept a PR, agree? As for your side note. We do not have an officially supported way of adding symbols....

Support validation when `monetized` is used

need to figure out why test is failing, hang tight