Ramon
Ramon
I don't think we should have a separate function to flush each Exporter and one to flush the internal stats buffer. We should have a single global Flush/Shutdown/Close function that...
@odeke-em anything more to add or can this issue be close?
We can do this without breaking the API by just deprecating the old way instead of removing it immediately. Removing the api-breaking tag.
I would prefer to generalize this slightly differently. Instead of exposing the general ability to add tags (which is more powerful than required), let's rename `WithRouteTag` to `WithRoute` so that...
What if we extracted the logic for HTTP request processing, something like: ```go func (h *ochttp.Handler) Start(req *http.Request) *http.Request { ... return req.WithContext(newCtx) } func (h *ochttp.Handler) End(req *http.Request, route...
Yeah, that's fine I think. We should just note that it isn't safe to call it from a separate goroutine. Can we call it `ochttp.SetRoute(req, route)` and have it set...
Yeah, I can imagine that there would be cases where you might not have convenient access to the http.Request so using context seems fine. If the tag list is not...
We will probably need similar things for `stats` and `tag` so maybe we should collect all these under a single `mocks` package.
Not that I know of. I think partially the reason is that the interface is so simple to implement that most people just create an implementation themselves in test code.