Luigi Semenzato
Luigi Semenzato
I think this may be enough. I verified that it stops the leak. ``` diff --git a/src/Common/FDInputStream.hpp b/src/Common/FDInputStream.hpp index 8528e84..8dc0485 100644 --- a/src/Common/FDInputStream.hpp +++ b/src/Common/FDInputStream.hpp @@ -57,6 +57,7 @@ namespace...
Would you like me to formally send a patch? BTW we're patching this for ChromeOS at Google. https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/6521787
Thank you @hartwork, I hadn't seen this. Get well soon @Cropi!
Thank you for looking into this and please forgive mistakes---it's my first GitHub pull request... ;)
(I updated this commit with `git push --force` to include the `fixes` clause.)
> @semenzato I didn't see this because it didn't reference #666 or CC me anywhere but great to have now, thank you! 👍 > > I did find keyword `override`...
I am not sure if there is anything else I can do here to get this done. Thanks!
I wish I could be of more help, but my C++ knowledge is also quite superficial. I'll see if I can find the time to dig in a bit more....