semaphore icon indicating copy to clipboard operation
semaphore copied to clipboard
verified publisher icon semaphore-protocol

`@semaphore-protocol/data` uses utility functions that can be replaced by `@zk-kit/utils`

Open cedoor opened this issue 1 year ago • 6 comments

Description

@semaphore-protocol/data uses checkParameters to check if the parameter types are the correct ones. Since there's already a @zk-kit/utils dependency, it could use the zk-kit utility error-handlers functions directly, and avoid duplicating code.

cedoor avatar May 07 '24 13:05 cedoor

Can you assign this to me please?

jancris100 avatar May 07 '24 16:05 jancris100

Hey @jancris100 sure. I just assigned you this issue. Please, let us know if you have questions.

vplasencia avatar May 07 '24 16:05 vplasencia

Hey! I'm Hannah, a developer studying with the PSE Core program :) If this isn't in progress already I would be happy to take it on. @vplasencia @jancris100

hannahredler avatar Aug 30 '24 09:08 hannahredler

Hey @hannahredler, there's already a PR for this issue. Let's try to ping the author and ask them first.

@jancris100 there are some issues to solve in your PR: https://github.com/semaphore-protocol/semaphore/pull/782. Let us know if you've time to work on it. Otherwise no problem, just a double-check before re-assigning the issue.

cedoor avatar Sep 02 '24 09:09 cedoor

This issue i already finish it a long time ago

jancris100 avatar Sep 02 '24 14:09 jancris100

@jancris100 great! Could you reply to my comments there? Some conflicts also need to be resolved.

cedoor avatar Sep 02 '24 15:09 cedoor