selsta
selsta
Since we do not allow external payment IDs anymore, it might make sense to completely remove them from the v2 API enpoints. Only integrated addresses from now on. On the...
@U65535F I will get the specification updated to remove `tx_payment_id`, you can update the APIs.
URI spec has been updated to remove `tx_payment_id` and support multiple addresses. https://github.com/monero-project/monero/wiki/URI-Formatting
> parse_uri_v2 will classify it as unknown parameter and push to the vector of such parameters. (payment_id=id format). Can you clarify this?
No questions currently, I just have to go through all the code one more time and I didn't have time for it yet.
I have time to go over it again today.
Please squash, then everything is good from my side. I will see if I can find another person who wants to take another look over it, if not we can...
I will have one more round of suggestions tomorrow, but no major issues left.
@j-berman is this ready to review or merge? the corresponding CLI PR has been merged and is included in v0.18.4.0.
@johnalanwoods General fund is around 8k. > will replenishing the CCS impact protocol development? No, the general fund isn't usually used for funding active development but more for emergencies like...