Basil Baumgartner

Results 10 comments of Basil Baumgartner

> I think you might be confusing symfony's `FormType` with `DataTableType`. AFAIK, the `DataTableType` should not be used to create forms. (`createFromType` is not the same as `createFormType`). But apart...

> The OptionsResolver is already used to validate options on column. This can be interesting for DataTableType. To do this and avoid BC, it would be necessary to create a...

I looked at the addToCart process of sylius (`Sylius\Bundle\OrderBundle\Controller\OrderItemController`) and the customerOptionsPlugin stuff around it. Now my head hurts. I'll use B24 as shortcut for Brille24 and S for Sylius...

Alright alright. I don't have much time on hand right now. I will try to update my PR tho. Hopefully, it won't take too much time. As for the extensibility....

Maybe I wasn't clear with the Fixture. It's true that the ProductFixture class extends the Sylius Fixture. That was not was I meant. The service id (sylius.fixture.product) is overwritten. If...

No? That would is happening now with extending as they overwrite each other. If you decorate the Fixture like now, calling the parent/inner method and then adding more, there is...

Oh, I see. Ok, now I get it. Indeed, this is a problem. I think the only solution is to let the bundle user extend it. Basically add a chapter...

Alternatively, the production fixture could be dropped altogether. And a product option added to customer options and group. So when loading the customer options they can be linked to existing...

@roukmoute any update? I just required hashids v3.1 and it still requires sensio/framework-extra-bundle v6.2.4 I am using symfony v6.4.3, so I think it shouldn't need sensio, right? I assume it...

Do you need a repository for it? Maybe I misunderstood it. I thought you can simply create a PR on the contributors-repository? https://github.com/symfony/recipes-contrib I didn't make any recipes yet either....