Sayed Adel
Sayed Adel
> During the meeting, I think Sayed preferred it be in numpy. I don't have a strong opinion. I would prefer to keep it in NumPy for a while until...
@abhishek-iitmadras, > No performance regressions. It's surprising to hear there are no performance regressions, especially on architectures like x86. As far as I understand, Highway will fall back to the...
@abhishek-iitmadras, > I am extremely sorry for the huge delay in replying to you regarding benchmarking performance on AVX512 and AVX2, as I was busy with some other framework optimization....
There is ongoing work to bring full sorting, including support for emulated half-precision and later argsort: - https://github.com/numpy/numpy/pull/29829 - https://github.com/google/highway/pull/2737 Currently facing an issue related to compilation time on Highway,...
I have updated the benchmark to use GCC tests instead of Clang, as GCC is commonly the default compiler for wheels on Linux. At the moment, I only have access...
Ah, regarding the reverted #23399, as discussed in the [thread/C6EYZZSR4EWGVKHAZXLE7IBILRMNVK7L/](https://mail.python.org/archives/list/[email protected]/thread/C6EYZZSR4EWGVKHAZXLE7IBILRMNVK7L/). The default precision for f64 is set up to 1ULP, including for large arguments, with the ability to add a...
Along with `if constexpr`, other language features like `fold expression` also imply C++14, which brings `template-variables`. It's a critical move to simplify the interface, clean it up, and speed up...
> but the -0 != 0 part is surprising, do we really need that? IMHO, treating `-0.0 < 0.0`, and `-0.0 != 0.0` as true is numerically reasonable for sorting....
> apart from that good to go. Not, yet. CI trigger errors due to missing `float16_t`'s operator+ by clang & gcc compiler: https://github.com/google/highway/actions/runs/18126110238/job/51581687220?pr=2737 ```Bash /home/runner/work/highway/highway/hwy/contrib/sort/sort_unit_test.cc:84:73: error: invalid operands to binary...
I'm going to avoid using operator + in here instead for now to bypass ci errors: https://github.com/google/highway/blob/746c513ae5486c9d955f3bbaae7b746b4fb30b23/hwy/contrib/sort/sort_unit_test.cc#L80-L85