Sayed Adel

Results 53 comments of Sayed Adel

@r-devulap, sorry, currently I suffer from lack of time, please just give me 2 or 3 days max to give a full review.

@r-devulap, as we discussed in the triage meeting, it's OK to accept it as a submodule.

@mattip, I was looking at it. I'm preparing a patch to implement intrinsics for non-saturating packing and test special fpu cases, which are needed to avoid complexity and guarantee fair...

@mattip, > would it be OK to merge this as-is, and then later apply that patch? Definitely not, I'm going to review it in place without waiting to merge extra...

I have made few changes to the code to allow auto-vectorization, and here the result on x86 with avx2 enabled: ```Bash ❯ lscpu Architecture: x86_64 CPU op-mode(s): 32-bit, 64-bit Address...

> Wow! Thanks Sayed! Not that good, the GCC compiler was expected to apply something similar to Harley-Seal popcount algorithm for optimized machine code generation. However, it defaulted to using...

You're right - we're bumping the default `cpu-baseline` and users can change this. I agree. Downstream packagers need to decide their own compatibility targets but we will no longer need...

@tacaswell, I've updated the release note to be more clear about the CPU baseline change.

> There are comments about fixes needing to be backported. Has this happened? Not yet, there are only two bugs that have been found; they should be back-ported (#30026). -...