segogoreng comments

Results 6 comments of


                                            segogoreng

suite: fix panic if a WithStats suite skips a test early

Hi @dolmen It's been 2 months, so I created a [new PR](https://github.com/stretchr/testify/pull/1802), basing from @FGasper's branch and it's rebased with the latest master. Could you check that out, please? Thank...

add NonPositive and NonNegative functions.

Hi @brackendawson This is a pretty old PR, do you think this is still relevant?

suite: Skipping a test in BeforeTest prevents test execution but not AfterTest

Hi @brackendawson I'm new to this project and open source projects in general, and I'm looking for "beginner" issues to contribute to. Would you say if this is beginner's friendly...

suite: Skipping a test in BeforeTest prevents test execution but not AfterTest

Let me check my understanding of the issue. If `testing.T.Skip` is called in `BeforeTest` or `SetupTest`, we should skip both `AfterTest` and `TearDownTest`? This one is not the current behavior....

suite: Skipping a test in BeforeTest prevents test execution but not AfterTest

Hi @brackendawson , thanks for the answer. > Whether the corresponding teardown method needs to be run depends on if the user called skip at the start or end of...

assert: add Kind

Hi @dolmen It's been a while since the last comment. I created a new PR #1803 based on the @matinFT's branch, addressing your comments here, and also adds the corresponding...