Sebastian Seggewiß

Results 28 comments of Sebastian Seggewiß

> @seggewiss can we just do there npm install without clean? @shyim In my opinion we could do a `npm install`.

I quickly checked this. The Component emitting this event already has the current context. This could easily be achieved. https://github.com/shopware/platform/blob/trunk/src/Core/System/SalesChannel/Context/CartRestorer.php#L85

Thank you for your feature request. This is something we can't offer in the near future. Overriding modules would come with several side effects. Those side effects are for example...

> From what I am seeing in our app, modules are being resolved breadth-first instead of depth-first. For example: > > ```ts > // index.js > export * from './a/index.js';...

@Akryum I tried to create a performance profile like you described in your guide. But funny enough with the dev setup of the extension our application works fine. With the...

@Ceddy610 Sorry but we can not accept your PR as it breaks the third level behaviour for navigation items with a path.

> @seggewiss No worries. Could you provide which is the intended behavior and how this PR broke it? The third level no longer expands for navigations with a path.

This works correctly with the latest release: ![image](https://github.com/shopware/shopware/assets/39218577/6eeed46e-33b7-4ad3-ad08-5458e96c5ed0) Should you face this issue again feel free to reach out again.

> @shyim It looks like the initial problem from this PR was fixed with [d12d442#diff-7f512493902f72ede1d14ddbd7e4501ab1fff8b40782e3775bf4e7cbcf193ca7](https://github.com/shopware/shopware/commit/d12d4423dd0e2916d4e347dd2f4bb206a21bff8d#diff-7f512493902f72ede1d14ddbd7e4501ab1fff8b40782e3775bf4e7cbcf193ca7) Should this still get merged to display the warn message for developers? We can still...

Thank you for contributing 😊