segatrade

Results 27 comments of segatrade

Maybe delete duplicates, because it's make code dirty, obsolete and more difficult for beginners? https://github.com/AI4Finance-Foundation/FinRL/blob/master/tutorials/3-Practical/FinRL_MultiCrypto_Trading.ipynb https://github.com/AI4Finance-Foundation/FinRL-Meta/blob/master/tutorials_notebook/3-Practical/FinRL_MultiCrypto_Trading.ipynb https://github.com/AI4Finance-Foundation/FinRL/blob/master/finrl/finrl_meta/env_cryptocurrency_trading/env_multiple_crypto.py https://github.com/AI4Finance-Foundation/FinRL-Meta/blob/master/finrl_meta/env_crypto_trading/env_multiple_crypto.py Actual version in FinRL-Meta as I understand

We just need to clean step by step. Delete all duplicates, because they with time start create confusion and chaos. We can always import them from one project to another...

2 more duplicates in one repo: `https://github.com/AI4Finance-Foundation/FinRL-Meta/blob/master/tutorials/2-Advance/MultiCrypto_Trading/MultiCrypto_Trading.ipynb` `https://github.com/AI4Finance-Foundation/FinRL-Meta/blob/master/tutorials/3-Practical/FinRL_MultiCrypto_Trading/FinRL_MultiCrypto_Trading.ipynb` If do you think my feedback is useless please tell me, I will not write.

Thank you I mean FinRL obsolete vs FinRL-Meta. Added (vs FinRL-Meta) in old comments. In FinRL-Meta some files have new commits and updates vs FinRL

> 3. tutorials -> 1-Introduction -> FinRL_StockTrading_NeurIPS_2018 -> .py, .ipynb This is best way I think. For every tutorial we have directory. .py and .ipynb inside it together. It will...

Got connected bug when tried run CryptoEnv with rllib from tutorial: ``` File "/home/usr0/venvpy38/lib/python3.8/site-packages/ray/rllib/evaluation/rollout_worker.py", line 1698, in _validate_env if not env.observation_space.contains(dummy_obs): AttributeError: 'NoneType' object has no attribute 'contains' ```

This is good feature > "exchange":{ > "name": "binance", > "reduced_fees_strategy"{ > "enable": true, > "process_throttle_secs": 3600, > "currency": "BNB", > "upper_limit_ratio": 0.0015, > "lower_limit_ratio": 0.0005, Percents are better than...

Why it's not merged yet?(