Farhad Safarov

Results 30 comments of Farhad Safarov

@mpdude thanks for the explanation 👍 . I got it but I have some concerns: - adding `'valid' => false` to `$vars` assumes it is not valid by default which...

@mpdude thank you. I will try to fix test failures on `master` and after that a rebase might be needed

@mpdude after merging master, the remaining failing tests are related to this changes. Could you please take a look at them?

hi @Punk-UnDeaD, Thank you for the issue. The code seems valid. Can you please create a PR for it?

@VincentLanglet hi, I think it is hard avoid it by just creating stubs. Correct parent node should be set for each child node builder as a parent. I have no...

@VincentLanglet can you check if it is working as expected with v2.3.0? it might be fixed with https://github.com/psalm/psalm-plugin-symfony/pull/170

@ThomasLandauer it seems there is a second thought on it https://github.com/symfony/symfony/issues/46546#issuecomment-1146637184 https://github.com/symfony/symfony/pull/46581 might fix the issue

@VincentLanglet thank you for the report. > Is it something that can be improved in the symfony plugin (and how ?) or should psalm be more careful with the parent...

Hi @VincentLanglet, I simplified the problem to this https://psalm.dev/r/2d3d231b58 Maybe psalm should handle this case. @muglug what do you think?