Wasim Lorgat

Results 148 comments of Wasim Lorgat

I wonder if this _just works_ already? 🤔

Is this still an issue? I can't find the `` tags in your current README.md

Here's a minimal repro: ```python from fastcore.basics import eval_type eval_type('list[float|int]', {}, {}) ``` The issue is that fastcore's backport of py310-style annotations (e.g. `float|int`) doesn't support generic types, see this...

I wonder if we should be evaluating types for `show_doc` at all? If we don't, we would avoid https://github.com/fastai/nbdev/issues/1116 too. cc @jph00

Thanks so much for the response! I took a look at the integration test logs and looks like it’s the clash with future annotations 🥲 Will try see how hard...

@jph00 a few updates on progress here: All fastai tests are now passing locally 🚀! (Except `20a_distributed` which fails with `OSError: [Errno 24] Too many open files`. I suspect this...

Hi @PhilipVinc, thanks for the response! I’m not at a PC atm so can’t share any code examples just yet Yep, we’re using `add_conversion_method` atm. What I was referring to...

Ahhh yes that’s exactly it - can’t believe I missed that! Python does indeed support type variables now. I’d be keen to poke around plum to see what it would...

Agreed, many thanks to @wesselb and @PhilipVinc for the amazing contributions 😄 it's been a privilege working with fastcore and plum! @jph00 this is now a drop-in replacement supporting all...

@jph00 https://github.com/fastai/fastcore/pull/415/commits/fce1adb2c6c42af1d9c0a005bfc83a5b820e9a51 fixes the Python 3.7 incompatibility that [broke CI](https://github.com/fastai/fastcore/runs/6870921177?check_suite_focus=true#step:6:91). Tests pass locally on Python 3.7