Wasim Lorgat comments

Results 148 comments of


                                            Wasim Lorgat

nbdev breaks subcaptions on figures

@jph00 @hamelsmu, curious to hear your thoughts too.

How to guide for testing

Sounds interesting @Jacobluke-! I'm not familiar with "graphical testing", could you please share some graphical testing plugins you've enjoyed using?

Setting to enable Vim Editor only for certain filetypes

+1 I find that if VIM mode worked perfectly in notebooks I would still prefer to disable it. Otherwise you have 3 different modes and that feels like too much...

nbdev_test parallel() process re-use results in hard to debug behaviour

I agree that this is hard to debug and ideally we wouldn't leak state. It's been a while but IIRC these are two possible fixes: - Figure out why [changes...

Only run pre-commit hooks on modified files

Good idea! `nbdev_clean` currently doesn't take any positional arguments so we could make the change so that it optionally takes a list of files

vscode extension for nbdev which cleans notebooks

Relevant documentation: https://code.visualstudio.com/api/extension-guides/notebook

vscode extension for nbdev which cleans notebooks

Thanks @rebornix! Reopening this issue.

Document how to Ignore files/folder when running nbdev_test

@ADubinA you can add an empty `.nodoc` or `.notest` file to directories that you want to disable documentation or tests. For example using `touch /your/dir/.notest`.

Remove or update conda-forge package

The conda-forge package seems to be maintained by a third party: https://github.com/conda-forge/nbdev-feedstock, so I'm not sure what we could do about that. The tutorial does suggest to install from the...

`show_doc` rendering issues with TorchScript functions

It looks like `@torch.jit.script` really clobbers your function e.g. it sets `__module__ = 'torch.jit'` and deletes both `__name__` and `__qualname__`. I'm not sure how to resolve that... One workaround might...