Sam Stepanyan

Results 40 comments of Sam Stepanyan

Hi @itsdivyanshjain , yes, it is a valid point to improve code quality. Please do check and review PR #403 first - DeepSource tool was used to analyse the code...

sorry @Mrinank-Bhowmick we have a few more important functional enhancements coming to the report, your proposal is purely cosmetic. I am going to keep this PR open as a remind...

@Ali-Razmjoo do you have any availability to review the PRs?

Nettacker does not work on python 3.13 compatibility issues - we can solve the docker image vulns by moving to a different 3.11 image release. None of the vulnerabilities listed...

Getting the same error, looks like the requirements.txt are not included in the PyPi package?

@Mrinank-Bhowmick - this module failed my test, it failed to find the correct user/password pair when bruteforcing. I had no time to investigate further, likely the exceptions are not handled...

This is not backwardly-compatible with Docker v20.10 as it fails with error: `Error response from daemon: dockerfile parse error line 9: unknown instruction: MKDIR` ![Screenshot 2023-10-23 at 01 17 32](https://github.com/OWASP/Nettacker/assets/20112179/25058f7b-c6a5-429e-870b-b88e08b55310)...

Base image was updated to python-3.11.7-slim in #804 to minimise vulnerabilities while still staying on the python 3.11.x branch.