Sergey G. Brester

> The result is save to /etc/fail2ban/jail.d/fail2ban-shodan-internetdb.csv. Why? I mean for which purposes is it saved there? Rather the question is why this is necessary to the time of ban?...

> Second is necessary to the time of ban. Again, for which exactly? You did not explain what you (or a user of that info) would achieve with that. And...

I know that it could be helpful and what it would tell the user... Again this does not explain why it is needed at **time of ban** (what I was...

Just a marker for me: after merge of #1460 rebase branch `geoip-banfactor`.

I meant it introduces failure in CI now, so to pass [Codespell](https://github.com/fail2ban/fail2ban/actions/runs/6960640646/job/18940559083?pr=3636) flow it must be ignored. As for proposal to use topos, I don't think we need 2 spell...

Just by the way, may be this RFE will be also interesting here - #2304 (especially see https://github.com/fail2ban/fail2ban/issues/2304#issuecomment-590276134) > This is some kind of inefficient when doing every 5 minutes...

Confirmed. Just `eval` is evil, thus I'd rewrite it somehow, either with `ast.literal_eval` or with RE parsing... Since `literal_eval` is safe against "injections" and other kind of malicious evaluations, I'd...

Moreover, thinking about that a bit, it doesn't look as a good fix at all. The problem here is the ambiguity by `(123,345)` supplied to `unban` command, since fail2ban allows...

Thx! > Changed the modification with a small refactoring in order to avoid the recursive method. This would cause issues as it would recurse on the TUPLE_ID which must be...

Done. However there is probably still one case to "solve" - `banip`, that must also accept tuple IDs now for consistent reasons.