facebook
[Fiber] Move Profiler onPostCommit processing of passive effect durations to plain passive effect
We used to queue a separate third passive phase to invoke onPostCommit but this is unnecessary. We can just treat it as a plain passive effect. This means it is interleaved with other passive effects but we only need to know the duration of the things below us which is already done at this point.
I also extracted the user space call to onPostCommit into ReactCommitEffects. Same as onCommit. It's now covered by runWithFiberInDEV and catches.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| react-compiler-playground | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Sep 15, 2024 10:30pm |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Comparing: fc5ef50da8e975a569622d477f1fed54cb8b193d...a963eaa41ea0f71ca5baa42599bb5e9c8914ac9c
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
| Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |
|---|---|---|---|---|---|---|
| oss-stable/react-dom/cjs/react-dom.production.js | = | 6.68 kB | 6.68 kB | = | 1.82 kB | 1.82 kB |
| oss-stable/react-dom/cjs/react-dom-client.production.js | +0.03% | 509.13 kB | 509.28 kB | = | 91.08 kB | 91.09 kB |
| oss-experimental/react-dom/cjs/react-dom.production.js | = | 6.69 kB | 6.69 kB | = | 1.83 kB | 1.83 kB |
| oss-experimental/react-dom/cjs/react-dom-client.production.js | +0.03% | 514.10 kB | 514.23 kB | = | 91.80 kB | 91.81 kB |
| facebook-www/ReactDOM-prod.classic.js | +0.02% | 604.72 kB | 604.86 kB | = | 106.86 kB | 106.86 kB |
| facebook-www/ReactDOM-prod.modern.js | +0.04% | 580.95 kB | 581.16 kB | +0.01% | 103.00 kB | 103.01 kB |
Significant size changes
Includes any change greater than 0.2%:
Expand to show
| Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |
|---|---|---|---|---|---|---|
| facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-profiling.js | = | 347.39 kB | 346.69 kB | = | 60.51 kB | 60.38 kB |
Generated by :no_entry_sign: dangerJS against 08139d7e4548925772b5ce46abb62302ef32613c
I think maybe one possible effect of this is that this fires while inside an offscreen tree because it's possible that the passive effects are still mounted.