Sébastien Ros

Results 786 comments of Sébastien Ros

I have no clue where the difference could be. But it's easier to make something faster when you have a baseline. If you want to use this as an opportunity...

If I were you I'd keep this PR around if you want to use it and make Pidgin faster. If you are willing to and have the time for that.

Adding rationale: A trace shows that some `hook_handle` instances are not disposed correctly and induce a `Finalize()` call from the GC.

Please let me know if you think the issue I am describing is not related, I will file a new one, but it's also related to `SafeHandle`. I was looking...

I get this error when patching the files. ``` [STDERR] Unhandled exception. System.IO.FileNotFoundException: Could not load file or assembly 'Ben.StringIntern, Version=0.1.0.0, Culture=neutral, PublicKeyToken=a6d206e05440431a'. The system cannot find the file specified....

The first issue you mentioned is already covered by a unit test and was ported. I created a unit test with the script you pasted and it worked fine. Could...

Note to my future self: It works on http://esprima.org/demo/parse.html so the fix should be easy to find by just doing a step by step debug session and find out the...

I can't repro this issue. I added this test and it works fine both on master and dev. Can you provide a better unit test? ``` [Fact] public void ShouldRegularExpressionGH44()...

I can't repro these issues if I use the parser directly, or the ScanRegex method. I think that the issue is in the Esprima.Sample source that you all seem to...

I think the issue is related to this PR that I seem to have skipped https://github.com/jquery/esprima/pull/1439/files Each node is passed to `proxyDelegate` such that external components can react to each...