Sebastian Rath
Sebastian Rath
I have the same issue in my project, but on Windows. I could reproduce the error message from the OP (also here checked only on Win). ``` WARNING in ./node_modules/nodegit/build/Release/nodegit.node...
Typos fixed. About `log` vs. `branch` I would use the log command to report more detailed information about the branches. `branch` on the other side would simply list all branches
Awesome, I like 👍 Edit: Just had an idea, what about `--contains-info=branches,commits,history,files`
`--debug/--verbose` is a functionality where`--branch/--history` somehow is different, but just a detail, we can go with latter
Makes sense!
I just leave the following comments and ideas here. For Unix-based systems, it seems to be a no-brainer to implement it. A platform-independent solution is a little bit more tricky....
@belkarx Thanks so much for the PR. Please give me a few days to review and test this. I'm back in the office next week.
Not closed yet, wait until unit-test is completed https://github.com/Snowtrack/SnowFS/blob/bd22f7194c4770086b597216d3d6199d85a3baf6/test/9.cli.ts#L116-L119
Hey belkrax, thanks so much for your report! Interesting, it seems your Linux OS doesn't support [lsof](https://man7.org/linux/man-pages/man8/lsof.8.html). If you change this line: https://github.com/Snowtrack/snowfs/blob/c1e27daaf92b79c9524c5d8cf8a70e600862b1d8/src/io_context.ts#L700 to ```typescript return Promise.resolve(); ``` you should...
I still think there is room for improvement in this code. We can either improve the error message, find an alternative on Linux, or skip `lsof` on machines where it...