Sebastian Meyer

Results 135 comments of Sebastian Meyer

This PR contains no changes?!

Closing this pull request because it contains no changes. Please reopen if you just forgot to push the changes to your branch.

I'll have a look after my vacation.

I think the issue is, that we have our own initialization in [`AbstractController::initialize()`](https://github.com/kitodo/kitodo-presentation/blob/e58ad14c23bb4b0cde0a0d2d2c47043631831ec1/Classes/Controller/AbstractController.php#L97) and there only the extension configuration is parsed (L106): ```php // Get extension configuration. $this->extConf = GeneralUtility::makeInstance(ExtensionConfiguration::class)->get('dlf');...

You placed a lot of JavaScript files in `Resources/Private/JavaScript/`. Are you sure those shouldn't be put in `Resources/Public/JavaScript/` instead, because they need to be accessible by the client? Also, please...