Sebastian Meyer

Results 129 comments of Sebastian Meyer
trafficstars

@frank-ulrich-weber: Could you please fix the PHPStan and Codacy issues? Also, I think you need to add `typo3/cms-scheduler` to `composer.json` in order for this to work (this should also help...

Please rebase this to `master` and resolve the corresponding conflicts.

I've deployed this branch on https://test.dfg-viewer.de for testing. Examples can be found [here](https://intranet.slub-dresden.de/display/DFGVIMU/Konkordanz+der+Dateinamen).

I've updated https://test.dfg-viewer.de to the current [1e87169](https://github.com/kitodo/kitodo-presentation/pull/910/commits/1e87169e1963b91779885657ef31d25ad73148fb), but this leads to errors: [example](https://test.dfg-viewer.de/index.php?id=2&tx_dlf%5Bid%5D=https%3A%2F%2Fgit.uni-paderborn.de%2Fapi%2Fv4%2Fprojects%2F3852%2Frepository%2Ffiles%2FMETS_MODS%252Fmets_M0005.xml%2Fraw%3Fprivate_token%3Dglpat-eZHpuqu-MPyzZzwFvy9B&no_cache=1) Unfortunately there are no messages in the admin log pointing to the cause.

OK, the problem was the recent renaming of `Resources/Public/Javascript` to `Resources/Public/JavaScript`, because the typoscript configuration of https://github.com/slub/dfg-viewer still addresses the old path. I added a symbolic link for the old...

Thanks for investigating! I didn't even know they changed that for TYPO3... @oliver-stoehr Could you please consider this for the remaining pull requests which add new fixtures?

According to [documentation](https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ExtensionArchitecture/FileStructure/ExtTablesSql.html) this looks fine, but tests are still failing. Are we not using the extension manager to set the database up?

I think that's not a bug, but a feature. There is a difference between `page` and `pagination`: `page` is the image number, always an unique integer starting with 1 and...

Since this is not compatble with TYPO3 v10, we should introduce this change with Kitodo.Presentation 6.x, which will support TYPO3 v11 and v12.

There are two different templates for the ListView in Kitodo.Presentation: - Resources/Private/Templates/ListView/Main.html - Resources/Private/Templates/Collection/List.html The former is used as a default for any kind of list, that does not have...