Sebastian Baumhekel

Results 21 comments of Sebastian Baumhekel

While looking at the source code, I just noted that it is possible to adjust the binary transferred oids by using [`QueryExecutor.setBinaryReceiveOids`](https://github.com/pgjdbc/pgjdbc/blob/master/pgjdbc/src/main/java/org/postgresql/core/QueryExecutor.java#L343) or [`QueryExecutor.setBinarySendOids`](https://github.com/pgjdbc/pgjdbc/blob/master/pgjdbc/src/main/java/org/postgresql/core/QueryExecutor.java#L350). And the [`QueryExecutor`](https://github.com/pgjdbc/pgjdbc/blob/master/pgjdbc/src/main/java/org/postgresql/core/QueryExecutor.java) itself can be...

I created a pull request https://github.com/pgjdbc/pgjdbc/pull/2556 to be able to get existing oids for binary sending and receiving from the `QueryExecutor` as well as add new oids to it. This...

> This sounds like a wrong level of abstraction to me. I do not understand what do you want to achieve This pull request only complements the already existing API....

> QueryExecutor is driver-private class, and I do not understand what are you going to achieve Just to clarify my intentions: I am working on [postgis-java-ng](https://github.com/sebasbaumh/postgis-java-ng), which provides the geometry...

So what could be a solution for that? Push it up to [`PGConnection`](https://github.com/pgjdbc/pgjdbc/blob/master/pgjdbc/src/main/java/org/postgresql/PGConnection.java#L142) like the data type handling? And is there some tag or something to see supported API? Your...

@vlsi and @davecramer I see both your points, thank you for clarifying this. At first I just wanted to go for implementing [`PgBinaryObject`](https://github.com/pgjdbc/pgjdbc/blob/master/pgjdbc/src/main/java/org/postgresql/util/PGBinaryObject.java) on the classes I use for reading...

> > I would basically register binary types when [`PgConnection.addDataType`](https://github.com/pgjdbc/pgjdbc/blob/master/pgjdbc/src/main/java/org/postgresql/jdbc/PgConnection.java#L714) gets called and the type is implementing `PGBinaryObject`. > > This seems more rational to me So we should definitely...

I created a separate commit in the pull requests for these changes: For types implementing `PGBinaryObject` I automatically try to enable binary transfer. If the oid of the type is...

I just squashed the existing commits and rebased them on the current master to be more in line with the current development. It seems one of the AppVeyor builds fails...

Okay that's it... :smile: I have cleaned up all my changes and then squashed everything into a single commit. Furthermore I have added a new unit tests to not only...