Sebastiaan Marynissen

Results 29 comments of Sebastiaan Marynissen

I know that using Babel solves the issue, but still I think that there's a place for this, because: - When using platforms like electron, you don't need to use...

Have a look at [chai-spies](https://www.npmjs.com/package/chai-spies) for this. It's a plugin which allows you to do something like this: ```js const chai = require('chai'); const chaiSpies = require('chai-spies'); chai.use(chaiSpies); let vm...

The implementation of the feature can be straightforward: ```js class Socket { constructor() { this.buildError = err => this.io.buildError(err); } errorBuilder(fn) { this.buildError = fn; } request(...args) { return new...

Wouldn't it be an option to not include a polyfill and leave it up to the user? If the user targets browsers that don't support promises, he would either: -...

@disruptek The reason is that I have a lot of computed properties, so I would like to "group" them within separate models where the models containing the "raw values" serve...

Ah, I see. Yeah, those are nasty cases. One solution I can think of is to walk down the prototype chain and then verify that it's something like `IntArray extends...

Actually I've been thinking, wouldn't it be "cleaner" to just pass the value *as is* to `crypto.randomFillSync({})` and then rethrow any errors? For example, if you run ```js const nodeCrypto...

Okay, I will implement something with the passthrough approach and file a PR for it. Just fyi, making it 100% [spec compliant](https://w3c.github.io/webcrypto/#Crypto-method-getRandomValues) will be difficult because according to the spec,...

Well, forget the above. I was under the impression that ```js nodeCrypto.fillRandomSync(new FloatArray32(length); ``` would throw an `ERR_INVALID_ARG_TYPE` as well, but apparently it doesn't. However, I see that in Node...

I filed a PR (#3396) where the webcrypto api is used if available (meaning on Node 16 and 18), but it fails the web platform tests because the `DOMException` thrown...