Sean Tan

Results 21 comments of Sean Tan

@poxrud I believe this pull request works because as per the README, `require "capistrano/rsync"` is added in our Capfile which loads the `rsync.rb`. Thus, it enhances the `load:defaults` task before...

Just to add, I have success in setting up default settings in my capistrano tasks (lib/capistrano/tasks/*.cap) by simply enhancing the `load:defaults` task, and the settings can be overwritten in `deploy.rb`...

I guess it is a matter of preference. My preference is to go with `require 'capistrano/rsync'` which follows the general convention of requiring external gem support below `require 'capistrano/deploy'`. Take...

@moll Don't mind me nagging... is there any chance we can get the fixes pulled into master soon? We're already getting 3 similar PRs that fixes the same show-stopper problem...

@SkyWriter it could be due to the default options problem highlighted in https://github.com/moll/capistrano-rsync/pull/2 @moll Can you look at my pull request or at least @webflo's pull request soon to narrow...

@SkyWriter Thanks for trying the PRs. Will appreciate your feedback. :)

@SkyWriter try setting the following ``` set :scm, :rsync set :rsync_scm, :git ```

Glad to be of help :) I agree pt. 1 should be stated in the README to make it obvious. I didn't notice the need to manually create the rsync_cache...

It seems that the typings at https://www.npmjs.com/package/@types/lunr is quite outdated. For example for lunr v2.1, the index is immutable after creation, but the typings provided still defines the mutation functions...