Sean McBride
Sean McBride
@sonatique what do you think?
@hjelmn does this look right to you?
@osy could you take a look at this?
@osy Yes reading. This change is as a result of a -Wthread-safety compiler warning. According to existing comments: ``` /* lock protects claimed_interfaces */ usbi_mutex_t lock; unsigned long claimed_interfaces; ```...
Like I said in the other issue, this is more of a demo. Instead of actually reviewing this PR, you could just do the same perl command yourself and commit...
lgtm I think if you squash all the commits the warning about 'Commits must have verified signatures.' would go away. But if you don't know how to do that, no...
That may or may not be a typo. I believe the space prepends a space for positive numbers (and negative values will have the negative sign, as usual). However, I...
Have you tested this with Thread Sanitizer? Could you?
> Before any of my changes, TSan emits a lot of warnings: Yes, I should have said: those are known. I was wondering if your changes fixed them by any...
I don't know/understand this code well, so I don't feel I'm really qualified to review it confidently, but it looks reasonable. The commit message has lots of great explanation (thanks!)...