Sean McBride

Results 419 comments of Sean McBride

>Add a test in /tests/ to run the code snippet given in the docs and check if the OS-functions succeed? I can't speak for him, but I think that's what...

1.0.25 is old. Can you try master?

Have you used Thread Sanitizer before? Could you try with it?

> I just sent you the invitation to join libusb project as an admin. Thanks a lot! Accepted successfully. Thanks.

> Does this imply a master freeze starting from now? I hope not. We currently have some momentum going, and there are several PRs I'd like to see merged...

Would be nice to get these 3 in: https://github.com/libusb/libusb/pull/1696 https://github.com/libusb/libusb/pull/1686 https://github.com/libusb/libusb/pull/1694

168f84f1ac3e209cc46d1c9b07a896fc895cdd8a looks to be related. So @thewtex maybe you have some idea for this one?

Sorry, where is that code? I don't seem able to find it in master... PS: TSan is not static analysis, it's a runtime checker.

Ah, quite different! I'll try adding those 2 lines...

@thewtex so I added those 2 lines at the end of that function, but alas it does not fix the TSan error.