Sean Golob

Results 7 comments of Sean Golob

Hi PB team! I think I have a similar issue except with the `card` component. When I try to leverage `as="picture"` on the `Card.Image`, I am seeing a missing rounded...

Hi there! I am experiencing a similar issue to these with the "River" element when I try to leverage the `picture` tag. The `picture` element is missing a `height: 100%`...

@rezrah I've been piling into this issue a bit recently. I can easily split out the 3 separate comments into separate issues if that makes things easier for you or...

https://github.com/primer/brand/issues/929 https://github.com/primer/brand/issues/930 Issues filed! We can consider all of my comments on this PR out of scope. Thanks @joshfarrant !

As this is purely a DX issue, I am unsure if `bug` is the correct label for this. Let me know if this is tagged appropriately. Also, we have a...

@danielguillan Another issue I noticed is that when you pass `as={undefined}`, it causes the heading level to use the default heading level of the `Heading` component (which is h2). Similar...

Sure thing! For every Primer Brand component we support, we have a reusable model in Contentful. So we may have 50 pricing options components in Contentful that all use the...