Sean
Sean
Yes, I agree. Truthfully it was a quick fix at first, as it was blocking me from something deemed more important. Circled back and fixed based on the suggestion.
Yes, it is. I'm assuming it has to do with the assumption the colon needs to be encoded when using encodeURIComponent, where it is expected in the auth field.
Also, I can remove lib/queue, if you want to merge it. I didn't want to publish my branch onto npm, but still needed it for a project - so I...
URL.format, and just not encoding the colon in the auth field, both work because the colon gets encoded with encodeURIComponent. Does your method work for you? I would be surprised...
Have you tested it? Because what I am saying is that your version yields username**%3A**password, whereas my first commit and this current commit both give username**:**password, and I am having...
They don't escape the colon though - (https://github.com/nodejs/node/blob/master/lib/url.js#L933)
Has this been reviewed at all in the last year?